370: Fix thumbnail 404 regression in nginx static-file location - #408
Merged
turegjorup merged 1 commit intoApr 28, 2026
Conversation
The regex location for static files (jpg, png, etc.) had no try_files directive, so first-time requests to /media/cache/resolve/... 404'd without ever reaching Symfony. Adding the same fallback as location / lets LiipImagineBundle generate missing thumbnails on demand. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
tuj
approved these changes
Apr 28, 2026
turegjorup
merged commit Apr 28, 2026
c49aac4
into
feature/update-infrastructure-for-mono-repo
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #370.
Summary
location ~* \.(jpg|jpeg|png|gif|...)block ininfrastructure/nginx/etc/templates/default.conf.templatewins overlocation /for any URL ending in.jpg. It had notry_filesdirective, so nginx fell back to the defaulttry_files $uri =404. First-time requests to/media/cache/resolve/<filter>/<path>.jpg404'd without ever calling PHP, breaking LiipImagineBundle thumbnail generation.try_files $uri /index.php$is_args$args;to the static-file location so missing files hand off to Symfony, matching the implicit 2.6.1 behavior where everything flowed throughlocation /.Why nginx, not PHP
Putting thumbnail resolution into a PHP-layer
file_get_contentson the resolve URL would block the response thread on synchronous image processing per item, add per-collection-item latency on serialization, and tightly couple the DTO output layer to image generation. The nginx fallback is request-routed by the proxy, runs once per missing thumbnail (cached on disk thereafter), and keeps the API contract clean.Test plan
curl -I https://<host>/media/cache/resolve/thumbnail/<path>.jpgreturns302(was404).200withCache-Control: public, immutable.🤖 Generated with Claude Code